Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index issue with uppercase characters in domain names #140

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Fix index issue with uppercase characters in domain names #140

merged 2 commits into from
Nov 4, 2022

Conversation

iwangpeng
Copy link
Contributor

Fixes #117

@lipoja
Copy link
Owner

lipoja commented Nov 4, 2022

@iwangpeng Thank you for this PR! It is nice catch!
May I ask you to add unit tests so we would prevent regressions? Once it is done I will merge it!

Thank you!

@lipoja lipoja self-requested a review November 4, 2022 09:05
@lipoja
Copy link
Owner

lipoja commented Nov 4, 2022

@iwangpeng Thank you for your time and this PR!

@lipoja lipoja merged commit 5f1b9ec into lipoja:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipoja lipoja lipoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong indices with uppercase characters in domain name
2 participants
@iwangpeng @lipoja