Skip to content

Commit

Permalink
remove leftover firewall rules (#35)
Browse files Browse the repository at this point in the history
  • Loading branch information
liprec committed May 5, 2020
1 parent 84e8c19 commit 1e3f5e5
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions deploy-aas-db/1.2.0/deploy-aas-db.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ switch ($connectionType) {
# Create TSML command
$tsmlCommand = PrepareCommand -Model $model -Overwrite $overwrite -ModelName $modelName

# Remove leftover firewall rule
if (($deleteFirewallRule) -and ($addedFirewallRule)) {
Write-Verbose "Remove leftover firewall rule"
RemoveCurrentServerFromASFirewall -Server $aasServer -AzContext $azContext
}

# Set firewall and SP context
switch ($loginType) {
"user" {
Expand Down

1 comment on commit 1e3f5e5

@digihunch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$addedFirewallRule is always false (without being referenced or assigned earlier) here so line 123 never gets executed.

Please sign in to comment.