[7571] add ai feedback to comment

[m4ra]

to be merged after this one #6
relevant files in this PR:

	modified:   adhocracy-plus/config/urls.py
	modified:   apps/moderatorfeedback/api.py
	modified:   apps/moderatorfeedback/serializers.py
	modified:   tests/moderatorfeedback/conftest.py
	modified:   tests/moderatorfeedback/test_moderator_comment_feedback_api.py
	added:      apps/ai_reports/serializers.py

respective api urls:

http://localhost:8004/api/comments/<comment_pk>/aicomments/
http://localhost:8004/api/contenttypes/<contant_type_pk>/objects/<comment_pk>/comments/<comment_pk>/

need to create an ai_report for testing purposes, see the test i added.
@hklarner need help with debugging why ai feedback still not part of the comment serializer, while I can access the ai_feedback api response alone. see screenshots:

[github-actions]

Coverage report

Total coverage

Status	Category	Percentage	Covered / Total
🔴	Statements	12.62%	90/713
🔴	Branches	14.84%	54/364
🔴	Functions	10.42%	27/259
🔴	Lines	24.49%	569/2323

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 45d197a

[hklarner]

@hklarner need help with debugging why ai feedback still not part of the comment serializer, while I can access the ai_feedback api response alone.

You added ai_feedback to the CommentWithFeedbackSerializer but the Comment model does not have a field ai_feedback so this spec gets silently ignored. Basically the thing that does the mapping between serializer fields and the underlying model fields is the ModelSerializer (it is inherited: CommentWithFeedbackSerializer -> CommentSerializer -> ModelSerializer).

I would suggest to rename this field to ai_report:

class CommentWithFeedbackSerializer(a4_serializers.CommentSerializer):
    ai_report = AiReportSerializer(read_only=True)

because it introduces less vocabulary and renaming when we talk about things.

If you want to rename the serialized field you can also specify the source:

class CommentWithFeedbackSerializer(a4_serializers.CommentSerializer):
    ai_feedback = AiReportSerializer(read_only=True, source="ai_report")

[m4ra]

@hklarner

You added ai_feedback to the CommentWithFeedbackSerializer but the Comment model does not have a field ai_feedback so this spec gets silently ignored. Basically the thing that does the mapping between serializer fields and the underlying model fields is the ModelSerializer (it is inherited: CommentWithFeedbackSerializer -> CommentSerializer -> ModelSerializer).

indeed, but the moderator_feedack field is also not present in the Comment model, so I don't get how that one works. Anyhow I resolved to use DRF relation serializers, in this case, the StringRelatedField since ai_report has a one-to-one relation with a comment, and the renaming of the serializer field to ai_reportworked because this is the name of the reverse relation we specified in the AiReport model. Thanks for pointing out the name change.

[m4ra]

@goapunk can you take over the review on this one, since Hannes is away?

[goapunk]

@goapunk can you take over the review on this one, since Hannes is away?

yes, will do (sorry, closed accidentally)

[goapunk]

nice, looks good to me!