apps/cms: change button for col_cta_block to be more inline with the … #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
force-pushed
the
jd-2024-06-fix-cta_block_button_styling
branch
from
89c889d
to
ca7f3bc
Compare
…behavior of the background_cta_block fixes #42
goapunk
force-pushed
the
jd-2024-06-fix-cta_block_button_styling
branch
from
ca7f3bc
to
63a46c6
Compare
hom3mad3
reviewed
Jun 17, 2024
| &:active, | ||
| &:focus-within { | ||
| text-decoration: underline; | ||
| border-color: $border-color; |
There was a problem hiding this comment.
is this second declaration of border-color here necessary?
There was a problem hiding this comment.
yes, otherwise the border color will be black instead of white on hover/focus
hom3mad3
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…behavior of the background_cta_block
fixes #42
testing: create two block (background block and normal (col-) cta block) and check button behavior
Tasks