Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ks 2021 04 user interplated translations #125

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Apr 27, 2021

I changed the classification choices to lowercase in the model.. sorry about that, should have done when adding it. But now it was annoying, because I needed it to be displayed lower case (which I did before with styling, but removed it now, because in german we need upper case also) and just changing it at some other point would make the translations not work anymore, because the translated string was upper case... probably this is even more confusing, sorry /:

@Rineee Rineee force-pushed the ks-2021-04-user-interplated-translations branch from 0a56c65 to b9912f6 Compare April 27, 2021 15:54
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Should we also add the new translation strings in this PR?

@Rineee Rineee force-pushed the ks-2021-04-user-interplated-translations branch from b9912f6 to 18dd515 Compare April 27, 2021 16:36
@fuzzylogic2000 fuzzylogic2000 merged commit 6d1fd31 into master Apr 28, 2021
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2021-04-user-interplated-translations branch April 28, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants