Pm 2021 03 rebase aplus take 2 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to work around certain browsers not assuming this by default.
…n order to reinitialize jQuery
so it can be pulled by others
…not an already used email
…not already used as an email
…hat username doesnt already exist neither as email, nor as upper/lower case
…tyle clean fixes #31
philli-m
force-pushed
the
pm-2021-03-rebase-aplus-take-2
branch
from
0043d30
to
46fead1
Compare
|
I just checked moderation tab and there are no projects shown I think? |
|
Yeah, some stuff is not there: |
|
@Rineee Mattermost is down so not sure if you saw, all my projects are listed in mod tab and I have cached js on aplus too so didn't think it was an issue but as said will look at it in the morning, if you commit what you did in a seperate commit and i'll take a look then :) |
…ck. webpack.common: adding moderation dashboard entry point back with new format
philli-m
force-pushed
the
pm-2021-03-rebase-aplus-take-2
branch
from
46fead1
to
aa4f842
Compare
|
@Rineee you were right about the mod dashboard entrypoint, mine must have been cached, have re-added. Network tab shows 302 on a+ too but on a force refresh it goes away on both so I think it's fine. |
|
Nice! But we don't merge this, but force push on master, right? And keep this branch or the old master or both as backup or how would we do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested maps and interactive event to check js elements and it all seems to be working.