-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should we use html_date everywhere? #4017
Comments
@sabinammm s guess was that we might not need it anymore:
|
In Browserstack tested with integrated screenreader for:
I also checked a plan detail page with https://wave.webaim.org/ and it seems fine with the date as long as it is in a list item. To sum up: it is legible by those screen readers tested, without the use of html_date Question: Do we have a minimum standard yet that we use for accesssibility? @phillimorland is this enough for now to say that we do not need to use html_date anymore? |
@sabinammm the a11y web standard is set by https://www.w3.org/WAI/ I would just check there for the element or if it's now deprecated, also here all html elements are listed here with their uses https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time seems like time might be a more searchn engine thing which might be useful |
URL:
user:
expected behaviour:
behaviour: We do use our own template tag
html_date
in quite a few places, but seem to have forgotten in others (like herea4-meinberlin/meinberlin/apps/plans/templates/meinberlin_plans/plan_detail.html
Line 92 in fb7aaf2
important screensize:
device & browser:
Comment/Question: The main question to answer is: is the
html_date
better for a11y, because it wraps the dates in a html time element? @phillimorland do you know?a4-meinberlin/meinberlin/apps/contrib/templatetags/contrib_tags.py
Line 44 in 23922a3
Screenshot?
The text was updated successfully, but these errors were encountered: