apps/projects plans /contrib /ideas /mapideas /cms: added missing html_tag for… #4041
Conversation
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from c997cd5 |
sabinammm
force-pushed
the
sm-2021-12-06-add-time-html-tag-to-date-objects
branch
from
cc4f770
to
865f790
Compare
sabinammm
changed the title
sabinammm
changed the title
sabinammm
force-pushed
the
sm-2021-12-06-add-time-html-tag-to-date-objects
branch
from
865f790
to
3e99630
Compare
sabinammm
changed the title
| @@ -50,7 +50,7 @@ <h1 class="item-detail__title">{{ object.name }}</h1> | |||
| <div class="item-detail__meta lr-bar"> | |||
| <div class="lr-bar__left"> | |||
| <strong class="item-detail__creator">{{ object.creator.username }}</strong> | |||
| {% if object.modified %}{% trans 'updated on ' %}{{ object.modified|date }}{% else %}{% trans 'created on ' %}{{ object.created|date }}{% endif %} | |||
| {% if object.modified %}{% trans 'updated on ' %}{% html_date object.modified class='list-item__date' %}{% else %}{% trans 'created on ' %}{% html_date object.created class='list-item__date' %}{% endif %} | |||
There was a problem hiding this comment.
maybe we could break this very long lines into shorter blocks? just for readability. what do you think?
There was a problem hiding this comment.
Yes, that's a good idea. I will change it.
@khamui I was just writing an issue b/c I noticed the same for the Comments in a4. |
sabinammm
force-pushed
the
sm-2021-12-06-add-time-html-tag-to-date-objects
branch
from
3e99630
to
2466ade
Compare
…ml_tag foraccessibility to dates
sabinammm
force-pushed
the
sm-2021-12-06-add-time-html-tag-to-date-objects
branch
from
2466ade
to
c997cd5
Compare
|
@khamui I shortened the changed code lines in commit 1. Commit 2 I shortened just the way too long lines in these files and changed some indents. |
|
yeah! i think it makes sense to improve readability whenever possible, so fine if you shortened lines which are not related to the task, but improves readability. |
… accessibility to dates
Fixes #4017
In order to find out which templates should use the html_tag for dates, the code was searched for the date filter.
6 of the 7 templates changed had very similar lines that were changed. Only one was changed from a
blocktranstotransbecause adding the html_tag to the the blocktrans would break it.