Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test 5024: improve accessibility #4099

Closed
CarolingerSeilchenspringer opened this issue Dec 21, 2021 · 7 comments · Fixed by #4120
Closed

test 5024: improve accessibility #4099

CarolingerSeilchenspringer opened this issue Dec 21, 2021 · 7 comments · Fixed by #4120
Assignees
Labels
Dev: A11y Accessability issue, e.g. screen reader, tabbing order Prio: Low fix when there is time Status: On hold issue or PR paused

Comments

@CarolingerSeilchenspringer
Copy link
Contributor

URL: https://github.com/liqd/a4-meinberlin/issues
user: user without mouse
expected behaviour:
behaviour:
important screensize:
device & browser:
Comment/Question:
I found several issues related to accessibility, different depending on browsers and not all of them strictly related to this story:

  • Firefox: focus for map/list switch very hard to see (also focus above not well visible but this was not part of the story)
  • all browser: filter with tabbing in wrong order
  • Safari: focus missing for all proposals, map/list switch (and more above list, eg. call to action)

do we need to split this issue?

@CarolingerSeilchenspringer CarolingerSeilchenspringer added Dev: A11y Accessability issue, e.g. screen reader, tabbing order Prio: Low fix when there is time labels Dec 21, 2021
@CarolingerSeilchenspringer CarolingerSeilchenspringer changed the title test 5025: improve accessibility test 5024: improve accessibility Dec 21, 2021
@fuzzylogic2000
Copy link
Contributor

Is this only for the react list or does it need to be improved for all lists?

@CarolingerSeilchenspringer
Copy link
Contributor Author

@fuzzylogic2000 I didn't check the other lists for now. But we should make the new react list accessible. And if that goes together with what is on top of the page and is easy to include, please do so. If completely different issue, just concentrate on the list.

@philli-m philli-m self-assigned this Dec 22, 2021
philli-m added a commit that referenced this issue Dec 23, 2021
philli-m added a commit that referenced this issue Dec 23, 2021
@philli-m
Copy link
Contributor

Note: half fixed, will do safari and focus ring in seperate pull request

Rineee pushed a commit that referenced this issue Dec 23, 2021
@philli-m
Copy link
Contributor

philli-m commented Dec 28, 2021

@CarolingerSeilchenspringer cannot reproduce safari issue on my current set up: mac Big Sur v11.6 Safari v 15.0 @khamui can you have a quick check of th focus rings on safari?

the firefox issue is something that needs a bit of concept, we currently have 1 focus ring that denotes buttons and one that denotes links (the not very visible one) which is decided by the browser. If we want to change the link focus ring I would like to have some input from @mcastro-lqd as it will be everywhere and I don't want to add focus behaviour without a design.
button types can be seen here https://meinberlin-dev.liqd.net/components/#cl-buttons

@philli-m
Copy link
Contributor

Technical Note: should research sematic standard for buttons that are essentially links

@khamui
Copy link
Contributor

khamui commented Dec 29, 2021

I was checking on Safari v15.0.0 on MacOS BigSur (11.6). It turns out that Apple disables tab navigation by default. Can you check if it is working if you check the option in Safari Einstellungen -> Erweiter -> Über Tabulator jedes Objekt...@CarolingerSeilchenspringer?

@CarolingerSeilchenspringer
Copy link
Contributor Author

@khamui thanks, that was the solution for safari!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: A11y Accessability issue, e.g. screen reader, tabbing order Prio: Low fix when there is time Status: On hold issue or PR paused
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants