Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing 5209: search result #4254

Closed
CarolingerSeilchenspringer opened this issue Mar 10, 2022 · 4 comments · Fixed by #4261
Closed

testing 5209: search result #4254

CarolingerSeilchenspringer opened this issue Mar 10, 2022 · 4 comments · Fixed by #4261
Assignees
Labels
Prio: Medium fixed and released with next scheduled release Type: Wording issue related to wording or translations

Comments

@CarolingerSeilchenspringer
Copy link
Contributor

URL: https://meinberlin-dev.liqd.net/mapideas/2021-00629/
user: any
expected behaviour: when searching comments should display: "x Beiträge gefunden zu: [search word]" or respective "1 Beitrag gefunden zu: [search word]"
behaviour: see screenshot
important screensize:
device & browser:
Comment/Question:

Screenshot?
Bildschirmfoto 2022-03-10 um 10 51 05

@CarolingerSeilchenspringer CarolingerSeilchenspringer added Type: Wording issue related to wording or translations Prio: Medium fixed and released with next scheduled release labels Mar 10, 2022
@sabinammm
Copy link
Contributor

Wrong issue mentioned in PR, this issue remains open until a4 update is merged.

@CarolingerSeilchenspringer
Copy link
Contributor Author

I will reopen because I just realized that the plural form of "x Beiträge" only appears after reloading the page. When entering a 2 nd comment, it will say "2 Beitrag". Is there anything we can do about that?
screenshot: right after submitting comment
Bildschirmfoto 2022-03-16 um 11 30 38
?
screenshot: after reloading page
Bildschirmfoto 2022-03-16 um 11 30 55

@fuzzylogic2000
Copy link
Contributor

Hmm, yeah, there is no quick solution for this. We could when we add the comment to the state also update that number there, but that's kind of a lot of work for an edge case.
We probably rather want our comments to automatically update anyway? That would be an even bigger story, but worth the effort, I think. Currently it is also very weird that when many people comment at the same time, I have to reload to see the other comments.
Also, this is an a4 issue.

@fuzzylogic2000
Copy link
Contributor

Wait, and where does it do that? Not in the filter anymore, right? So, this is also a different issue. Will copy it over to a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Medium fixed and released with next scheduled release Type: Wording issue related to wording or translations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants