Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budgeting: detail link "x More" on tiles looks off #4575

Closed
khamui opened this issue Oct 18, 2022 · 5 comments · Fixed by #4591
Closed

Budgeting: detail link "x More" on tiles looks off #4575

khamui opened this issue Oct 18, 2022 · 5 comments · Fixed by #4591
Assignees

Comments

@khamui
Copy link
Contributor

khamui commented Oct 18, 2022

URL:
user:
expected behaviour: link should be vertically centered as in design
behaviour: is aligned to the bottom
important screensize:
device & browser:
Comment/Question:
Bildschirmfoto 2022-10-18 um 14 28 01

@fuzzylogic2000
Copy link
Contributor

The "More" also needs to be marked as translatable.

@khamui khamui self-assigned this Oct 18, 2022
@fuzzylogic2000
Copy link
Contributor

another minor issue: between 364-400px there is a line break between "2" and "More".

Originally posted by @goapunk in #4572 (comment)

@philli-m
Copy link
Contributor

@khamui I don't think we shouldn't use template literals inside the render as means the strings are not translated, also i'm not sure if its the clearest way to write it anyway specially when there is no need if we don't need it to be multi line, what do you think?

@khamui
Copy link
Contributor Author

khamui commented Oct 19, 2022

@phillimorland not sure if i follow the second part. Do you mean the wording x More is not clear? And the multi line should be avoided?

@philli-m
Copy link
Contributor

philli-m commented Oct 19, 2022

@khamui I mean we can just use normal concatenation if we don't need the string to be multiline right? like {x} {translated.more} there's no need for the the $ or ticks?! or does it do something more fancy I am not getting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants