-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6536] Kl 2022 10 label filter #4572
Conversation
fb0b384
to
480e5e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! two comments though :)
meinberlin/apps/contrib/templates/meinberlin_contrib/includes/proposal_list_item.html
Outdated
Show resolved
Hide resolved
meinberlin/apps/contrib/templates/meinberlin_contrib/component_library.html
Outdated
Show resolved
Hide resolved
0c7c34c
to
3d09f26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just some styling thingds
meinberlin/apps/ideas/templates/meinberlin_ideas/includes/idea_list_item.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! lgtm. Regarding the corresponding a4 (i think it is good), but wait for someone with expertise to merge that one first.
@Rineee Could you have a look at the a4? I will add the tests later. :) |
3d09f26
to
1a63d7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Alhough there are too many filters now and the sorting filter in list view is not in line anymore, but I will just add an issue as I guess we need design for that?
@Rineee Yes, I saw that, but it wasn't in the story... We need to ask what to do about that. 🤷♀️ |
@fuzzylogic2000 Ah yes, I overread that, sorry! I added an issue for now, feel free to edit/add. #4581 |
UPDATE: merged and updated a4, not depending anymore.
dedending on liqd/adhocracy4#1241
all list labels are cut off here, so no need to handle that.
I would also like to work on the detail views and use that list there. But that can also go into another PR!
Also, if there are all filters, it gets very full on the list view now. Are we meant to also do the button?