[6536] Kl 2022 10 label filter #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzylogic2000
force-pushed
the
kl-2022-10-label-filter
branch
from
fb0b384
to
480e5e5
Compare
fuzzylogic2000
changed the title
khamui
reviewed
Oct 18, 2022
meinberlin/apps/contrib/templates/meinberlin_contrib/includes/proposal_list_item.html
Outdated
Show resolved
Hide resolved
meinberlin/apps/contrib/templates/meinberlin_contrib/component_library.html
Outdated
Show resolved
Hide resolved
fuzzylogic2000
force-pushed
the
kl-2022-10-label-filter
branch
from
0c7c34c
to
3d09f26
Compare
goapunk
reviewed
Oct 18, 2022
meinberlin/apps/ideas/templates/meinberlin_ideas/includes/idea_list_item.html
Show resolved
Hide resolved
khamui
approved these changes
Oct 19, 2022
|
@Rineee Could you have a look at the a4? I will add the tests later. :) |
fuzzylogic2000
force-pushed
the
kl-2022-10-label-filter
branch
from
3d09f26
to
1a63d7e
Compare
Rineee
approved these changes
Oct 19, 2022
@Rineee Yes, I saw that, but it wasn't in the story... We need to ask what to do about that. 🤷♀️ |
@fuzzylogic2000 Ah yes, I overread that, sorry! I added an issue for now, feel free to edit/add. #4581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: merged and updated a4, not depending anymore.
dedending on liqd/adhocracy4#1241
all list labels are cut off here, so no need to handle that.
I would also like to work on the detail views and use that list there. But that can also go into another PR!
Also, if there are all filters, it gets very full on the list view now. Are we meant to also do the button?