refactor item detail templates #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. |
xi
reviewed
Apr 18, 2017
|
|
||
| @register.assignment_tag | ||
| def get_item_delete_url(item): | ||
| return get_item_url(item, 'delete') |
There was a problem hiding this comment.
Why are there all these additional tags? We can just use {% get_item_url object 'delete' as delete_url %}, right?
# Conflicts: # apps/budgeting/templates/meinberlin_budgeting/proposal_detail.html # apps/ideas/templates/meinberlin_ideas/idea_detail.html # apps/mapideas/templates/meinberlin_mapideas/mapidea_detail.html
|
LGTM, too. I feel that some documentation (how does this work, what conventions should I follow, why was this approach chosen over others) would be a good addition, but that can be done separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next steps would be to do the same with the create/update forms and possibly the delete view.
Right now, the
get_item_add_permissiontag is useless as there is no item to get the app_label/model_name. I felt it was out of scope of this pull request to get a solution for that one because this permission is only used in the list-view which ain't topic of this PR.