Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings/base.py: adding additional plugins to ckeditor and updating … #3098

Merged
merged 2 commits into from Sep 9, 2020

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Sep 3, 2020

…unload filename so doesn't clash with plugins

  • The preview is broken after save but the iframe remains so it's 'working' this might be a long standing problem though according to some issues I found
  • It also has the capability added to all ckeditors for testing purposes but I think we only want it on the collapsible element one but until we are happy with whats happening it's good to have the tester options.
  • The nocookie URL from youtube may or may not solve our problem, I didn't find much on how to add the alert though?!
  • And apparently travis is failing?! I have only just notice that

@philli-m philli-m force-pushed the pm-2020-ckeditor-plugin branch 2 times, most recently from 843544d to 6cebe90 Compare September 7, 2020 12:32
@fuzzylogic2000
Copy link
Contributor

Cool! But when I fix travis (by also chaning unload_warning to warning_unload in webpack), I get the target not defined and not-stopping loading again. :( Don't know what to do about that! Or maybe, we don't use the warning_unload on the dashboard form pages with ck editor?

@fuzzylogic2000
Copy link
Contributor

Right, but we don't use different templates for the different dashboard forms. :(

@fuzzylogic2000
Copy link
Contributor

I just updated the ck editor. So before we go on, let's rebase! :)

@philli-m philli-m force-pushed the pm-2020-ckeditor-plugin branch 2 times, most recently from 27059f9 to d9899cf Compare September 8, 2020 12:37
@philli-m philli-m changed the title WIP settings/base.py: adding additional plugins to ckeditor and updating … settings/base.py: adding additional plugins to ckeditor and updating … Sep 8, 2020
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! It works!

@fuzzylogic2000 fuzzylogic2000 merged commit e7ce69e into master Sep 9, 2020
@fuzzylogic2000 fuzzylogic2000 deleted the pm-2020-ckeditor-plugin branch September 9, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants