WIP: webpack: IE11 fixes and workarounds #3481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpack 5 dropped ES5 polyfills, required for IE11 support. Explicitely specify ES5 support (`target`), making Webpack complain about everything that's missing. Install all required polyfills and make Webpack fall back to them.
This increases JS size again.
Closed
rmader
changed the title
|
Yeah I'm sorry, looks like this is blocked by parcel-bundler/parcel#1128 (there are a few similar bugs in different projects). Short story is that if we transpile all js dependencies (so it's compatible with IE11) we run into some babel error. It might be possible to somehow exclude all relevant packages, but I still haven't managed to pick the right ones. Another option is to wait and hope this gets fixed in babel. Either way I don't quite find a solution that makes IE11 work properly in embeds (and other areas) while not breaking mapbox for all browsers :( |
|
We no longer have to support IE11 so will close 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the first commit:
Sad thing is that we loose chunk dependencies again, resulting in bigger js files (like we had before #3440) and, because we now transpile almost all js (but mapbox because of a bug in babel), in longer build times, even during development.
The last point, longer dev build times, can probably be circumvented by moving the babel-loader config to production settings only.
Closes #3441