Kt 2021 11 pagination #3973
Merged
Kt 2021 11 pagination #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamui
force-pushed
the
kt-2021-11-pagination
branch
from
25836d3
to
1c34c26
Compare
Coverage reportTotal coverage
Show new covered files 🌑Coverage of new files
Show files with reduced coverage 🔻Reduced coverage
Report generated by 🧪jest coverage report action from 6139057 |
There was a problem hiding this comment.
Yeah, I like that all the logic is in the API now. But I think, that can be done with less code by using what the paginator already gives you.
https://www.django-rest-framework.org/api-guide/pagination/#custom-pagination-styles
meinberlin/apps/budgeting/api.py
Outdated
| return Response({ | ||
| 'status': True, | ||
| 'results': data, | ||
| 'meta': { |
There was a problem hiding this comment.
Same here: do you need all of that? Could you use the stuff you have?
added 2 commits
November 22, 2021 10:16
…settings.py creating better response structur from backend changing page_size to be set on backend only
khamui
force-pushed
the
kt-2021-11-pagination
branch
from
24d27a8
to
b51a300
Compare
…t add what is really needed
khamui
force-pushed
the
kt-2021-11-pagination
branch
from
b51a300
to
6139057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes, that might help to understand what was intended :)
This react pagination should behave like the old one (rather than what is in the current design)
I am not sure if i utilized the pagination django part correctly, any suggestions appreciated.
You might expect it a bit different, but:
page_size = 0 won't show all, but 0 --> edge case (we should use rather a large number)