Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] make icon switch component in react and use in toggles for project overview #3981

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Nov 24, 2021

wrote this for the proposal list but didn't need it in the end so re-purposed for project overview

@github-actions
Copy link

github-actions bot commented Nov 24, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 2.18% 27/1241
🔴 Branches 1.97% 14/710
🔴 Functions 3.41% 14/410
🔴 Lines 5.18% 189/3648

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show new covered files 🌑

Coverage of new files

Status Filename Statements Branches Functions Lines
🔴 meinberlin/apps/contrib/assets/CheckboxButton.jsx 0% 0% 0% 0%
🔴 meinberlin/apps/contrib/assets/IconSwitch.jsx 0% 0% 0% 0%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from ec51629

@philli-m philli-m force-pushed the pm-2021-11-map-switch branch 5 times, most recently from a4633fc to 47c3eb7 Compare November 25, 2021 11:08
@philli-m philli-m changed the title WIP [#5024] map list switch to react [refactor] make icon switch component in react and use in toggles for project overview Nov 25, 2021
endAria,
showStartObject,
showEndObject,
displayStartObject
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start and end used due to bootstrap adopting it

@khamui
Copy link
Contributor

khamui commented Nov 25, 2021

nice one! works fine

@khamui khamui merged commit b0cdbab into main Nov 25, 2021
@khamui khamui deleted the pm-2021-11-map-switch branch November 25, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants