Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kt 2021 12 js tests #4053

Merged
merged 12 commits into from
Dec 15, 2021
Merged

Kt 2021 12 js tests #4053

merged 12 commits into from
Dec 15, 2021

Conversation

khamui
Copy link
Contributor

@khamui khamui commented Dec 9, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.6% (+3.61% 🔼) 125/1302
🔴 Branches 7.58% (+3.92% 🔼) 56/739
🔴 Functions 9.26% (+2.55% 🔼) 40/432
🔴 Lines 16.35% (+5.29% 🔼) 634/3878

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 96d4682

philli-m
philli-m reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I think I get most of it but maybe @goapunk can take a look before merge?

meinberlin/apps/contrib/assets/__tests__/CountComponent.jest.jsx Outdated Show resolved Hide resolved
meinberlin/apps/budgeting/assets/__tests__/BudgetingProposalList.jest.jsx Show resolved Hide resolved
@khamui khamui changed the title Kt 2021 12 js tests WIP Kt 2021 12 js tests Dec 14, 2021
@khamui khamui marked this pull request as draft December 14, 2021 14:46
@khamui khamui marked this pull request as ready for review December 14, 2021 15:03
@khamui khamui changed the title WIP Kt 2021 12 js tests Kt 2021 12 js tests Dec 14, 2021
Kha added 11 commits December 15, 2021 08:22
apps/contrib/tests: Alert.jsx test added
0996c12
apps/contrib/tests: ErrorList.jsx test added
67622ea
apps/contrib/tests: IconSwitch.jsx test added
2471483
apps/contrib/tests: CountComponent.jsx test added
7cfbbd4
apps/contrib/tests: CheckboxButton.jsx test addedi and increase Count…
03e381e 
…Component coverage
apps/budgeting/tests: BudgetingProposalList.jest.jsx fixing annoying …
a18fec3 
…act(...) warning
apps/contrib/tests: fixing tests to work with renamed CountDown.jsx a…
e725227 
…nd removing snapshot
apps/documents/tests: ChapterForm.jsx test added
b7ced2a
apps/documents/tests: ChapterNav.jsx test added
601a7e9
apps/documents/tests: ChapterNavItem.jsx test added
d6b8ad6
apps/documents/tests: adjust test of CountDown.jsx to test active sta…
3edb7a7 
…te and inactive state
philli-m
philli-m approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! :)

@philli-m philli-m merged commit ba1cfd5 into main Dec 15, 2021
@philli-m philli-m deleted the kt-2021-12-js-tests branch December 15, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philli-m philli-m philli-m approved these changes

@fuzzylogic2000 fuzzylogic2000 Awaiting requested review from fuzzylogic2000

@Rineee Rineee Awaiting requested review from Rineee

@sabinammm sabinammm Awaiting requested review from sabinammm

@goapunk goapunk Awaiting requested review from goapunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khamui @goapunk @philli-m