Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plans/FilterRadio//FilterSecondary: refactor to ensure keyboard acces… #4194

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Feb 23, 2022

…sibilty and screen reader legibility and style for desktop

To do:

  • style typeahead for mobile

For further a11y improvements

  • check sectioning of forms
  • make sentance more sr friendly
  • check other checkbox and radio input fields to ensure they are seperated correctly

@github-actions
Copy link

github-actions bot commented Feb 23, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.6% 170/1770
🔴 Branches 7.01% 69/984
🔴 Functions 9.47% 52/549
🔴 Lines 13.61% 697/5120

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 520cedd

…sibilty and screen reader legibility and style
@philli-m philli-m changed the title WIP plans/FilterRadio//FilterSecondary: refactor to ensure keyboard acces… plans/FilterRadio//FilterSecondary: refactor to ensure keyboard acces… Feb 24, 2022
@philli-m
Copy link
Contributor Author

@fuzzylogic2000 I will take the a11y tasks with me to another pull request as I would like to clean up a few bits and update component lib but this will do for testing

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supercool!

@fuzzylogic2000 fuzzylogic2000 merged commit d624e5f into main Feb 24, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the pm-2022-02-filter-styling branch February 24, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants