Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5929] apps/plans: add explanation to export #4363

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

fuzzylogic2000
Copy link
Contributor

I used mB with Node 16 and the legacy-install.

@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.11% 162/1779
🔴 Branches 6.95% 67/964
🔴 Functions 9.01% 50/555
🔴 Lines 13.15% 677/5150

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 5cc3c9b

Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't get it running locally with n16 but code looks good

@philli-m
Copy link
Contributor

@fuzzylogic2000 to get it running I tried:
nvm install v16
npm install --legacy-peer-deps
make watch
was that it or did I miss a step?

@fuzzylogic2000
Copy link
Contributor Author

@fuzzylogic2000 to get it running I tried: nvm install v16 npm install --legacy-peer-deps make watch was that it or did I miss a step?

@phillimorland I deleted everything before doing that. So,

npm cache clean --force
make clean
nvm use v16
npm install --legacy-peer-deps
make install
make watch

I hope, that works!?

@philli-m
Copy link
Contributor

@fuzzylogic2000 thanks for pointer, still won't run make install for me :(

@fuzzylogic2000
Copy link
Contributor Author

Gah, well, maybe we can just merge, so it can be tested on dev? @phillimorland

@philli-m philli-m merged commit 7eb0dbc into main Jun 21, 2022
@philli-m philli-m deleted the kl-2022-06-export-plan branch June 21, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants