Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

budgeting/test_propsal_api: test search filter #4505

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Sep 22, 2022

Test is being skipped at the moment, so dont know if it makes sense to merge it now or later when pagesize has been reset?

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
And I am unsure about merging. There shouldn't be any conflicts when we undo the page size commits, but it is nicer to merge tests that are actually running. Let's wait for Monday?!

@fuzzylogic2000 fuzzylogic2000 force-pushed the ks-2022-09-budgeting-search-filter-test branch from 59cae98 to 2f6f736 Compare September 27, 2022 08:53
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@fuzzylogic2000 fuzzylogic2000 merged commit 54017e4 into main Sep 27, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2022-09-budgeting-search-filter-test branch September 27, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants