Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#8038] redesign moderator notes #5574

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[#8038] redesign moderator notes #5574

merged 1 commit into from
Mar 19, 2024

Conversation

hom3mad3
Copy link
Contributor

@hom3mad3 hom3mad3 commented Mar 18, 2024 •
edited
Loading

Description
Redesign the moderator notes element on the item detail page:
Screenshot 2024-03-18 at 16-51-01 Proposal 1 — meinBerlin

The moderator notes can be tested on /budgeting/2024-00014/

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@hom3mad3 hom3mad3 requested a review from goapunk March 18, 2024 16:02
@hom3mad3 hom3mad3 force-pushed the mr-2024-03-redesign-moderator-notes branch 7 times, most recently from cd4349e to 1b2a4b3 Compare March 19, 2024 11:05
goapunk
goapunk approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. I added some questions but feel free to merge if you think nothing needs changing

meinberlin/apps/contrib/templates/meinberlin_contrib/components/moderator_notes.html Outdated Show resolved Hide resolved
meinberlin/apps/contrib/templates/meinberlin_contrib/components/moderator_notes.html Show resolved Hide resolved
meinberlin/assets/scss/components_user_facing/_moderator_notes.scss Outdated Show resolved Hide resolved
@hom3mad3 hom3mad3 force-pushed the mr-2024-03-redesign-moderator-notes branch from 1b2a4b3 to 83b74a8 Compare March 19, 2024 16:00
@hom3mad3 hom3mad3 requested a review from goapunk March 19, 2024 16:02
goapunk
goapunk approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@goapunk goapunk merged commit 910fc80 into dev Mar 19, 2024
3 checks passed
@goapunk goapunk deleted the mr-2024-03-redesign-moderator-notes branch March 19, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goapunk goapunk goapunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hom3mad3 @goapunk