-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8161] poll redesign #5630
[#8161] poll redesign #5630
Conversation
3ba0aac
to
17759eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good but there are some broken elements (will leave them for @mcastro-lqd)
@@ -14,25 +14,25 @@ $warning: #f49e00 !default; | |||
$danger: #a72b1e !default; | |||
|
|||
$body-bg: #fff !default; | |||
$bg-secondary: #f2f2f2 !default; | |||
$bg-secondary: #f5f5f5 !default; // updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a convention that was started with the redesign, but makes no sense, i kinda gave up once i realized the state of the variables file. i will clean it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will leave it up to you, if it helps feel free to keep it
thanks, as mentioned already checked design with @mcastro-lqd but will let him double check once its in staging |
@hom3mad3 only needs an a4 update and then we can merge it |
17759eb
to
c0c59ac
Compare
now there are unrelated failing tests :/ not sure what is going on |
hmm, maybe the something changed since the last update, there were some fixes to the comments, will have a look tomorrow |
c0c59ac
to
c91d351
Compare
c91d351
to
806edfd
Compare
Describe your changes
Style overwrites for the poll module
Dependencies: liqd/adhocracy4#1640
testing: create a poll module (i.e https://meinberlin-design-dev.liqd.net/projekte/digital-participation-poll-for-mitte/)
Tasks