Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ks 2020 05 add fileupload forms dynamically #1886

Merged
merged 3 commits into from
May 12, 2020

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented May 11, 2020

Need to merge #1882 before.

Todo: when reloading the page, unsaved forms are not shown anymore, but counted in TOTAL_FORMS, thus no more new forms can be added

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I'll have have to have a deeper look later!

{% block title %}
{% if mode == 'create' %}
{% trans 'Create a new topic' %}
{% elif mode == 'update' %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! One could do with {% else %}, though, so that there is always something there (and it's one check less).

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! I will merge and see if can be improved afterwards!

@fuzzylogic2000 fuzzylogic2000 merged commit 5bd8543 into master May 12, 2020
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2020-05-add-fileupload-forms-dynamically branch May 12, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants