euth/offlinephases: add permission required mixin to offlineevent det… #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philli-m
approved these changes
May 18, 2020
fuzzylogic2000
approved these changes
May 19, 2020
There was a problem hiding this comment.
Cool!
Yes, it's right to go to the login-page, because you might be able to access it. But for the phases in the projects, there is a site showing a button to request membership. I think to make it super-sound, this should behave the same and also show that button. On the other hand there is no way to come to the offline event via links from the main page, so a 403 after logging in is just fine!
For the info: I say no, it's fine like this!
fuzzylogic2000
deleted the
ks-2020-05-add-permission-required-to-private-offlineevents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ail view
fixes #1209, but information of the project is hidden for all private projects..following the conversation in #1209, do we want to change that?