Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

Commit

Permalink
tests: Various fixes for Django 2.2
Browse files Browse the repository at this point in the history
  • Loading branch information
rmader committed Jul 11, 2019
1 parent 06b11d5 commit 77d2ce0
Show file tree
Hide file tree
Showing 17 changed files with 21 additions and 20 deletions.
2 changes: 1 addition & 1 deletion tests/budgeting/test_views_integration.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.budgeting import phases
Expand Down
4 changes: 2 additions & 2 deletions tests/documents/test_document_api.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import django
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse
from rest_framework import status

from apps.documents import models as document_models
Expand All @@ -17,7 +17,7 @@ def test_anonymous_user_can_not_retrieve_chapter_list(apiclient, module):
def test_anonymous_user_can_not_retrieve_chapter_detail(
apiclient, chapter, module):
# Assert that no detail route exists
with pytest.raises(django.core.urlresolvers.NoReverseMatch):
with pytest.raises(django.urls.exceptions.NoReverseMatch):
url = reverse(
'chapters-detail',
kwargs={'module_pk': module.pk, 'pk': chapter.pk}
Expand Down
2 changes: 1 addition & 1 deletion tests/documents/test_document_views.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target

Expand Down
2 changes: 1 addition & 1 deletion tests/ideas/test_idea_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import pytest
from django.conf import settings
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.comments import models as comments_models
from adhocracy4.ratings import models as rating_models
Expand Down
2 changes: 1 addition & 1 deletion tests/ideas/test_views_integration.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.ideas import phases
Expand Down
2 changes: 1 addition & 1 deletion tests/ideas/views/test_idea_create.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.ideas import models
Expand Down
2 changes: 1 addition & 1 deletion tests/ideas/views/test_idea_delete.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.ideas import models
Expand Down
2 changes: 1 addition & 1 deletion tests/ideas/views/test_idea_update.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.ideas import models
Expand Down
2 changes: 1 addition & 1 deletion tests/mapideas/test_moderation_access.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from apps.mapideas import phases
from tests.factories import PhaseFactory
Expand Down
2 changes: 1 addition & 1 deletion tests/mapideas/test_views_integration.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.mapideas import phases
Expand Down
2 changes: 1 addition & 1 deletion tests/mapideas/views/test_mapidea_create.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.mapideas import models
Expand Down
2 changes: 1 addition & 1 deletion tests/mapideas/views/test_mapidea_delete.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.mapideas import models
Expand Down
2 changes: 1 addition & 1 deletion tests/mapideas/views/test_mapidea_update.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.test.helpers import redirect_target
from apps.mapideas import models
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest
from dateutil.parser import parse
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.dashboard import components
from adhocracy4.test.helpers import redirect_target
Expand Down
2 changes: 1 addition & 1 deletion tests/partners/test_partner_detail_view.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from apps.partners import set_partner

Expand Down
3 changes: 2 additions & 1 deletion tests/partners/test_urlresolver.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ def test_partner_patterns_instance_ns(partner_factory):
auto_set_partner=False)
set_partner(partner)
urlconf = (partner_patterns(
url(r'^ns/', include(base_urlconf, namespace='instance-ns'))
url(r'^ns/', include((base_urlconf, 'instance-ns'),
namespace='instance-ns'))
),)

url_ = reverse('instance-ns:static-url', urlconf)
Expand Down
6 changes: 3 additions & 3 deletions tests/projects/test_dashboard_delete_view.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import pytest
from django.core.urlresolvers import reverse
from django.urls import reverse

from adhocracy4.projects import models
from adhocracy4.test.helpers import redirect_target
Expand Down Expand Up @@ -36,7 +36,7 @@ def test_user_cannot_delete(client, project_factory, user):
'pk': project.pk
})
response = client.post(url)
assert response.status_code == 302
assert response.status_code == 403
count = models.Project.objects.all().count()
assert count == 1

Expand All @@ -55,7 +55,7 @@ def test_moderator_cannot_delete(client, project_factory, user):
'pk': project.pk
})
response = client.post(url)
assert response.status_code == 302
assert response.status_code == 403
count = models.Project.objects.all().count()
assert count == 1

Expand Down

0 comments on commit 77d2ce0

Please sign in to comment.