This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
clean up styling landing page: fix wrapper width #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phillimorland I wanted to also set a max-width on the homepage__wrapper, but that will be left-aligned then and breaks the design. :( |
fuzzylogic2000
changed the title
philli-m
reviewed
Oct 14, 2019
There was a problem hiding this comment.
@fuzzylogic2000 Looking good, I would also reposition the images on ultra wide screens to remove the the minus margin so everything is inline, what do you think?
|
@phillimorland I think it is fine with the image like that, keeping some of the intended stuff. But if you think repositioning is better: go for it! |
|
@fuzzylogic2000 if it's not a priority i'll leave it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.