This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Mn 2019 10 combine speakup components #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 22, 2019 15:56
As this component will get its listitems now from the surrounding component as props, everything that is needed for pulling data from the API can be removed
after removing the fetch-questions-from-API functionality from the Statistics component the QuestionBox Component has to take care of sending the right data to it's new ChildComponent (the StatisticsBox)
MagdaN
force-pushed
the
mn-2019-10-combine-speakup-components
branch
from
deb9325
to
a8afdf8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two react components (QuestionsBox, StatisticsBox) on the same page pulling pretty exactly the same data from the same API-Endpoint. I moved the StatisticBox into the QuestionsBox and made the QuestionsBox pulling and preparing the data for the StatisticsBox. The StatisticsBox now receives the data via props.