Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

apps/organisation: Remove partners, include them in organisations #822

Merged
merged 1 commit into from
Jul 25, 2019
Merged

apps/organisation: Remove partners, include them in organisations #822

merged 1 commit into from
Jul 25, 2019

Conversation

rmader
Copy link
Contributor

@rmader rmader commented Jul 24, 2019 •
edited
Loading 

    In practice these always existed in a 1-to-1 relation. Having to support
    other combinations brings extra overhead we do not want anymore.
    
    This still includes the monkey-patched url overwrites, the middleware
    etc (though ported to organisation) to preserve all current behaviour.
    In a subsequent follow-ups we can clean this up step by step.
    
    https://github.com/liqd/a4-product/pull/822
    taiga 2136

@rmader rmader force-pushed the rm-2019-07-remove-partners branch 4 times, most recently from 536b177 to e3184d0 Compare July 25, 2019 09:44
@rmader rmader requested a review from MagdaN July 25, 2019 09:45
@rmader rmader changed the title WIP: Remove partners Remove partners Jul 25, 2019
MagdaN
MagdaN reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@MagdaN MagdaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmader! From looking at it looks good already - I added some question

apps/organisations/migrations/0005_copy_partner_data.py Outdated Show resolved Hide resolved
apps/organisations/__init__.py Show resolved Hide resolved
apps/organisations/middleware.py Show resolved Hide resolved
apps/organisations/models.py Show resolved Hide resolved
apps/organisations/urlresolvers.py Show resolved Hide resolved
@rmader rmader force-pushed the rm-2019-07-remove-partners branch 3 times, most recently from 65ab6b9 to 82aaac1 Compare July 25, 2019 13:03
rmader added a commit that referenced this pull request Jul 25, 2019
@rmader
apps/organisation: Remove partners, include them in organisations
82aaac1 
In practice these always existed in a 1-to-1 relation. Having to support
other combinations brings extra overhead we do not want anymore.

This still includes the monkey-patched url overwrites, the middleware
etc (though ported to organisation) to preserve all current behaviour.
In a subsequent follow-ups we can clean this up step by step.

#822
taiga 2136
@rmader rmader changed the title Remove partners apps/organisation: Remove partners, include them in organisations Jul 25, 2019
@rmader rmader force-pushed the rm-2019-07-remove-partners branch from 82aaac1 to 5a5340a Compare July 25, 2019 13:13
rmader added a commit that referenced this pull request Jul 25, 2019
@rmader
apps/organisation: Remove partners, include them in organisations
5a5340a 
In practice these always existed in a 1-to-1 relation. Having to support
other combinations brings extra overhead we do not want anymore.

This still includes the monkey-patched url overwrites, the middleware
etc (though ported to organisation) to preserve all current behaviour.
In a subsequent follow-ups we can clean this up step by step.

#822
taiga 2136
@rmader rmader force-pushed the rm-2019-07-remove-partners branch from 5a5340a to 310daf0 Compare July 25, 2019 13:41
rmader added a commit that referenced this pull request Jul 25, 2019
@rmader
apps/organisation: Remove partners, include them in organisations
310daf0 
In practice these always existed in a 1-to-1 relation. Having to support
other combinations brings extra overhead we do not want anymore.

This still includes the monkey-patched url overwrites, the middleware
etc (though ported to organisation) to preserve all current behaviour.
In a subsequent follow-ups we can clean this up step by step.

#822
taiga 2136
@rmader rmader force-pushed the rm-2019-07-remove-partners branch from 310daf0 to 267ae48 Compare July 25, 2019 14:46
rmader added a commit that referenced this pull request Jul 25, 2019
@rmader
apps/organisation: Remove partners, include them in organisations
267ae48 
In practice these always existed in a 1-to-1 relation. Having to support
other combinations brings extra overhead we do not want anymore.

This still includes the monkey-patched url overwrites, the middleware
etc (though ported to organisation) to preserve all current behaviour.
In a subsequent follow-ups we can clean this up step by step.

#822
taiga 2136
@rmader
apps/organisation: Remove partners, include them in organisations
1553458 
In practice these always existed in a 1-to-1 relation. Having to support
other combinations brings extra overhead we do not want anymore.

This still includes the monkey-patched url overwrites, the middleware
etc (though ported to organisation) to preserve all current behaviour.
In a subsequent follow-ups we can clean this up step by step.

#822
taiga 2136
@rmader rmader force-pushed the rm-2019-07-remove-partners branch from 267ae48 to 1553458 Compare July 25, 2019 14:47
@MagdaN MagdaN merged commit 4538beb into master Jul 25, 2019
@MagdaN MagdaN deleted the rm-2019-07-remove-partners branch July 25, 2019 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MagdaN MagdaN MagdaN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmader @MagdaN