This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
styling/pagination: use new pagination #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philli-m
reviewed
Aug 14, 2019
| display: inline-block; | ||
| min-width: 1.4em + 2 * 0.5em; | ||
| margin-right: -1px; | ||
| background-color: $body-bg; |
There was a problem hiding this comment.
I would set the background to $bg-light, I think the body-bg is the old background colour? and larger min width on the large screen buttons will make them look more even (i could have remembered that yesterday but brain was dead)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test it makes sense to set the paginations to 2:
a4-product/apps/cms/news/models.py
Line 37 in 0014c96
a4-product/apps/ideas/views.py
Line 58 in 0014c96