This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
apps/organisation: Do not assume an organisation to be present in templatetag #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmader
commented
Sep 18, 2019
rmader
commented
…platetag The templatetag was created during a cleanup of the previous 'partner' logic, which did not assume a partner to be present. Adapt the new logic to also not assume that. This one was tricky as the templatetag is loaded as part of the base-template, which again is loaded by the 404-template, which is loaded e.g. if there is no matching organisation for the query. The fact that the templatetag did not handle this let to a 500-error within the 404-error.
rmader
force-pushed
the
rm-2019-09-fixes
branch
from
1d25b7f
to
4afc7ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.