Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

copy DefinitelyTyped definitions to our repo #2141

Merged
merged 13 commits into from Mar 9, 2016

Conversation

xi
Copy link
Collaborator

@xi xi commented Mar 7, 2016

depends on #2137

We are currently installing DefinitelyTyped with bower. This has some major drawbacks:

  • It contains definitions for over 1500 projects. We only use 5. Downloading everything is really not required.
  • The project is active, but not exactly fast when it comes to contributions. There are currently over 400 open pull requests and over 600 open issues. So if there is a bug, you may have to wait a long time before an upstream fix is merged.

For these reasons I propose to just add the relevant definition files to our repo. This would allow the following workflow:

  • fix a bug locally
  • create an upstream pull request
  • update our copy from DefinitelyTyped once in a while (you may have to manually port local changes)

@der-john
Copy link

der-john commented Mar 9, 2016

works.

der-john pushed a commit that referenced this pull request Mar 9, 2016
copy DefinitelyTyped definitions to our repo
@der-john der-john merged commit 5d3a7bd into master Mar 9, 2016
@joka joka deleted the 2016-03-tb-rm-definitely-typed branch April 12, 2018 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants