This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
handle aborted requests in http/error.ts #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2016 19:38
|
looks good & improves error messaging. no additional tests failing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AJAX requests can be aborted, either explicitly (by calling
request.abort()), by a firewall or browser extension, or because the user navigated away. In this case the request data isnulland status is 0 (even though I also saw -1 in the wild). spec.Our error handling code expected
datato have a specific form, so it broke when a request was aborted and data was consequentlynull. I fixed that.This is somehow related to #2263 because I think it is caused by aborted requests. This does not fix that issue, though.