Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

use local nodejs for tests #2361

Merged
merged 2 commits into from May 30, 2016
Merged

use local nodejs for tests #2361

merged 2 commits into from May 30, 2016

Conversation

xi
Copy link
Collaborator

@xi xi commented May 30, 2016

My local acceptance tests failed, that's how I noticed that we don't use the local nodejs when using polytester.

Tobias Bengfort added 2 commits May 30, 2016 12:07
if called directly, both jasmin and protractor will use
`/usr/bin/env node`
they have been removed in #1259
@xi xi added the tests label May 30, 2016
@joka
Copy link
Collaborator

joka commented May 30, 2016

Do we still need to execute source source_env after this fix?

@xi
Copy link
Collaborator Author

xi commented May 30, 2016

I am not sure as I did not use source_env myself. But thanks for pointing out it existed. Now the question is: Should we use source_env or my version?

@joka
Copy link
Collaborator

joka commented May 30, 2016

I am not sure as I did not use source_env myself. But thanks for pointing out it existed. Now the question is: Should we use source_env or my version?

we should prefere your fix, it does not rely on manual steps.
Then we can remove the source_env script and the documentation

@xi
Copy link
Collaborator Author

xi commented May 30, 2016

Are you sure that source_env is no longer required? e.g. also sets LD_LIBRARY_PATH.

@joka
Copy link
Collaborator

joka commented May 30, 2016

Sre you sure that source_env is no longer required? It also sets LD_LIBRARY_PATH

This is needed if you compile python with PIL (image processing) and libjpeg/libpng.
As long as we have this as an installation option we should keep it.

What ist about A3_ROOT (see src/adhocrac_frontend/base.cfg)

@xi
Copy link
Collaborator Author

xi commented May 30, 2016

I think we can leave source_env as it is. It may be helpful in many situations, but with this change it is less required.

@joka
Copy link
Collaborator

joka commented May 30, 2016

I think we can leave source_env as it is. It may be helpful in many situations, but with this change it is less required.

you are right.

A3_ROOT is only used here: src/mercator/mercator/tests/fixtures/fixturesMercatorProposals1.py is this still needed by the frontend ?

@joka
Copy link
Collaborator

joka commented May 30, 2016

lgtm

@joka joka merged commit d913d39 into master May 30, 2016
joka added a commit that referenced this pull request Nov 13, 2016
small stability improvment:

	- Download tar archives from GitHub when possible (#2263)

        - Change default shorthand resolver for github from git:// to
https://

	- Fix ssl handling by not setting GIT_SSL_NO_VERIFY=false
(#2361)
@joka joka mentioned this pull request Nov 13, 2016
@joka joka deleted the 2016-05-tb-fix-test-node-version branch April 12, 2018 11:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants