Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mapbox-gl dependencies #1028

Open
Rineee opened this issue Mar 28, 2022 · 2 comments
Open

add mapbox-gl dependencies #1028

Rineee opened this issue Mar 28, 2022 · 2 comments
Labels
Type: Question issue or PR needing answer

Comments

@Rineee
Copy link
Contributor

Rineee commented Mar 28, 2022

URL:
user:
expected behaviour:
behaviour:
important screensize:
device & browser:
Comment/Question:
I might be totally wrong here, but from what I understood, we need to add mapbox-gl dependency in all projects using A4, since we are using mapboxgl-leaflet in adhocracy4/maps/static/a4maps/a4maps_common.js and that again is added to index.js. So wouldnt it make more sense to add that dependency in A4? @phillimorland @khamui
Screenshot?

@Rineee Rineee added the Type: Question issue or PR needing answer label Mar 28, 2022
@fuzzylogic2000
Copy link
Contributor

@goapunk @phillimorland Didn't we just add that to some other project? Or was it a4? I saw it in some PR...

@philli-m
Copy link
Contributor

@fuzzylogic2000 #1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Question issue or PR needing answer
Projects
None yet
Development

No branches or pull requests

3 participants