Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslintrc: remove static folder #1152

Merged
merged 6 commits into from
Aug 15, 2022
Merged

eslintrc: remove static folder #1152

merged 6 commits into from
Aug 15, 2022

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Jul 12, 2022 •
edited
Loading

  • make the js linting work again
  • fix existing lint errors

@github-actions
Copy link

github-actions bot commented Jul 12, 2022 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.37% 103/1099
🔴 Branches 9.55% 68/712
🔴 Functions 10.39% 37/356
🔴 Lines 15.65% 530/3386

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from c819f34

fuzzylogic2000
fuzzylogic2000 reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one tiny thing.

package.json Outdated Show resolved Hide resolved
philli-m
philli-m reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry forgot to submit yesterday

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@goapunk goapunk force-pushed the jd-2022-07-eslintrc-config branch from ee87e2f to b462fab Compare July 14, 2022 09:17
@philli-m philli-m mentioned this pull request Jul 18, 2022
Open
@philli-m
Copy link
Contributor

@goapunk is this ready for another review?

fuzzylogic2000
fuzzylogic2000 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe @phillimorland can have another look?

package.json Outdated Show resolved Hide resolved
philli-m
philli-m approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

adhocracy4/maps/static/a4maps/a4maps_choose_polygon_with_preset.js
@@ -184,7 +184,7 @@ function init () {
const polygon = JSON.parse(e.getAttribute('data-polygon'))
const bbox = JSON.parse(e.getAttribute('data-bbox'))

const map = maps.createMap(L, e, {
const map = createMap(L, e, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@philli-m philli-m merged commit eee4ce4 into main Aug 15, 2022
@philli-m philli-m deleted the jd-2022-07-eslintrc-config branch August 15, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philli-m philli-m philli-m approved these changes

@fuzzylogic2000 fuzzylogic2000 fuzzylogic2000 approved these changes

@Rineee Rineee Awaiting requested review from Rineee

@khamui khamui Awaiting requested review from khamui

Assignees

@philli-m philli-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goapunk @philli-m @fuzzylogic2000