Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8123] comments_async: add btn and row classes back in. #1601

Merged
merged 1 commit into from
May 27, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented May 27, 2024

There seems to be a bug in sass which makes the css size increase around 50x when a certain number of @extends is present. As a workaround for now I just added some of the classes back in so we don't need to extend them.

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk requested review from m4ra and hom3mad3 May 27, 2024 09:01
There seems to be a bug in sass which makes the css size increase around
50x when a certain number of @extends is present. As a workaround for
now I just added some of the classes back in so we don't need to extend
them.
@hom3mad3 hom3mad3 merged commit b64e86f into main May 27, 2024
3 checks passed
@hom3mad3 hom3mad3 deleted the jd-2024-05-fix-comments-again branch May 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants