Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace node-sass with sass #504

Merged
merged 1 commit into from
Oct 31, 2022
Merged

replace node-sass with sass #504

merged 1 commit into from
Oct 31, 2022

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Oct 26, 2022

  • replace node-sass with sass
  • move all dev dependencies into devDependencies

fixes #501

@goapunk goapunk force-pushed the jd-2022-10-replace-node-sass branch from f0aa8cb to 5b3bb5c Compare October 26, 2022 14:41
khamui
khamui approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@khamui khamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm. can be merged after conflicts are solved

@goapunk @philli-m
replace node-sass with sass
735f8f4 
* move all dev dependencies into devDependencies
philli-m
philli-m approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@philli-m philli-m merged commit f710cdd into main Oct 31, 2022
@philli-m philli-m deleted the jd-2022-10-replace-node-sass branch October 31, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philli-m philli-m philli-m approved these changes

@khamui khamui khamui approved these changes

@fuzzylogic2000 fuzzylogic2000 Awaiting requested review from fuzzylogic2000

@Rineee Rineee Awaiting requested review from Rineee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace node-sass with sass
3 participants
@goapunk @philli-m @khamui