Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/home: add microsite overview and detail pages and remove bg colo… #536

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Nov 2, 2022

…r from overview page

No migrations added.

@philli-m philli-m self-assigned this Nov 2, 2022
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just couple questions, if all find then good to have migrations added and be merged

apps/home/models.py Show resolved Hide resolved
@@ -3,7 +3,7 @@

{% block content %}
{% image page.intro_image max-1920x560 as intro_image %}
<div class="fullwidth ds-block--fullwidth {% if page.background_color %}ds-block--{{ self.background_color }}{% else %}ds-block--body-bg{% endif %}">
<div class="fullwidth ds-block--fullwidth ds-block--body-bg">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ds-block--fullwidth ds-block--body-bg can also go now as they were added to ensure colour was full width but might need testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, will remove!

Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@philli-m philli-m merged commit 5407827 into main Nov 2, 2022
@philli-m philli-m deleted the ks-2022-11-microsites branch November 2, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants