Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds-block: add overwrite for bg coloured blocks w images to ensure eve… #551

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Nov 7, 2022

…n margins fixes #388

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@@ -33,6 +33,18 @@
.background-image + .content-container *:not(.button) {
color: $black;
}

@media print {
background-color: none !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, nothing to do with this PR, but should we also set the text colour to black to make sure that the green blocks are also printed fine?

@fuzzylogic2000 fuzzylogic2000 merged commit 29a09b6 into main Nov 7, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the pm-2022-11-release-issues branch November 7, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#5649 Create Content Block with image and colourful background
2 participants