apps/measures/detail-page: make styles work for mobile #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philli-m
suggested changes
Apr 25, 2023
There was a problem hiding this comment.
I actually didn't pick up on it before but _measurs.scss would normally be called _meta.scss as that's the name of the component being styled in it, makes it easier to navigate when there are lots of components, we haven't been strict about it in this project but as this is purely just for the table I think we can be here.
|
|
||
| .meta-information__column { | ||
| margin-bottom: ($spacer * 2); | ||
| } |
There was a problem hiding this comment.
this spacing looks a bit bigger then on the designs tested on chrome, but I also struggled to get the actual amount from zeplin because of the elements being grouped, what do you think?
khamui
changed the title
khamui
force-pushed
the
kt-2304-styles-mobile
branch
from
65bebf0
to
5ff865a
Compare
khamui
force-pushed
the
kt-2304-styles-mobile
branch
from
5ff865a
to
af1873f
Compare
khamui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.