Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial content-security-policy #666

Merged
merged 1 commit into from
Apr 26, 2023
Merged

add initial content-security-policy #666

merged 1 commit into from
Apr 26, 2023

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Apr 25, 2023

  • use django-csp
  • add csp for dev to find issues

* use django-csp
* add csp for dev to find issues
@goapunk
Copy link
Contributor Author

goapunk commented Apr 25, 2023

this will eventually need some intense testing before used on prod

"www.berlin.de", "'unsafe-inline'"]
CSP_IMG_SRC = ["'self'", "berlin.de", "www.berlin.de", "www.gravatar.com"]
CSP_OBJECT_SRC = ["'none'"]
CSP_MEDIA_SRC = ["'self'"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not also mention youtube and vimeo or do we not need to given its in iframe?

Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, this we have to just try it. will merge but also want to ask @goapunk should we also have a report-to config to know about violations or does that not help us?

@philli-m philli-m merged commit b54c493 into main Apr 26, 2023
@philli-m philli-m deleted the jd-2023-04-add-csp branch April 26, 2023 14:20
@philli-m philli-m restored the jd-2023-04-add-csp branch April 26, 2023 15:00
@philli-m philli-m removed their assignment Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants