Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/*OverviewPages/templates: check for language_code and in case of… #696

Merged
merged 1 commit into from
May 8, 2023
Merged

apps/*OverviewPages/templates: check for language_code and in case of… #696

merged 1 commit into from
May 8, 2023

Conversation

khamui
Copy link
Contributor

@khamui khamui commented May 4, 2023

… de-ls hide intro image

philli-m
philli-m reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing I had a thought, do we definitely not want this on the microsites overview too?

apps/home/templates/apps_home/overview_page.html Show resolved Hide resolved
@khamui khamui changed the title apps/*OverviewPages/templates: check for language_code and in case of… WIP apps/*OverviewPages/templates: check for language_code and in case of… May 4, 2023
@khamui khamui force-pushed the kt-2304-hide-introimg-overviewpages-ls branch from dffbd27 to a3df5bd Compare May 4, 2023 12:15
@khamui khamui changed the title WIP apps/*OverviewPages/templates: check for language_code and in case of… apps/*OverviewPages/templates: check for language_code and in case of… May 4, 2023
@khamui khamui requested a review from philli-m May 4, 2023 12:15
fuzzylogic2000
fuzzylogic2000 approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@fuzzylogic2000 fuzzylogic2000 merged commit f178719 into main May 8, 2023
@fuzzylogic2000 fuzzylogic2000 deleted the kt-2304-hide-introimg-overviewpages-ls branch May 8, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzylogic2000 fuzzylogic2000 fuzzylogic2000 approved these changes

@goapunk goapunk Awaiting requested review from goapunk

@Rineee Rineee Awaiting requested review from Rineee

@philli-m philli-m Awaiting requested review from philli-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khamui @philli-m @fuzzylogic2000