Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/measures/fields of action: making links on detail page lead to f… #710

Merged
merged 1 commit into from
May 12, 2023
Merged

apps/measures/fields of action: making links on detail page lead to f… #710

merged 1 commit into from
May 12, 2023

Conversation

khamui
Copy link
Contributor

@khamui khamui commented May 9, 2023

…iltered overview page

fuzzylogic2000
fuzzylogic2000 reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! I just find the naming a bit confusing and some documentation would be good.

apps/measures/models.py Show resolved Hide resolved
apps/measures/models.py Outdated Show resolved Hide resolved
apps/measures/models.py Show resolved Hide resolved
@khamui khamui force-pushed the kt-2305-fields-of-action-links branch from 2db2797 to 46e2018 Compare May 10, 2023 13:14
@khamui khamui force-pushed the kt-2305-fields-of-action-links branch from 46e2018 to 00a7c6d Compare May 10, 2023 15:29
fuzzylogic2000
fuzzylogic2000 approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to change it to subset or should we merge like this? I am fine eith either.

@khamui
Copy link
Contributor Author

khamui commented May 11, 2023

Did you want to change it to subset or should we merge like this? I am fine eith either.

oh..i forgot, will change it!

@fuzzylogic2000
Copy link
Contributor

Did you want to change it to subset or should we merge like this? I am fine eith either.

oh..i forgot, will change it!

You didn't push it, right? 😝

@khamui khamui force-pushed the kt-2305-fields-of-action-links branch from b8ea2fb to 4fa283b Compare May 12, 2023 07:14
@khamui
Copy link
Contributor Author

khamui commented May 12, 2023 •
edited
Loading

@fuzzylogic2000 oh true....uppsala. should be there now

fuzzylogic2000
fuzzylogic2000 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fuzzylogic2000 fuzzylogic2000 merged commit d07ed1b into main May 12, 2023
2 checks passed
@fuzzylogic2000 fuzzylogic2000 deleted the kt-2305-fields-of-action-links branch May 12, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzylogic2000 fuzzylogic2000 fuzzylogic2000 approved these changes

@goapunk goapunk Awaiting requested review from goapunk

@philli-m philli-m Awaiting requested review from philli-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khamui @fuzzylogic2000