Skip to content

Commit

Permalink
small fixes for the release
Browse files Browse the repository at this point in the history
  • Loading branch information
aleoli committed Jun 24, 2022
1 parent 6adf440 commit 460a67a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ jobs:
with:
artifacts: ".cr-release-packages/*"
generateReleaseNotes: true
token: ${{ secrets.CI_TOKEN }}
allowUpdates: true
tag: ${{ needs.configure.outputs.commit-ref }}
name: ${{ needs.configure.outputs.commit-ref }}
Expand All @@ -324,7 +325,7 @@ jobs:
- uses: ncipollo/release-action@v1
with:
artifacts: "./liqoctl/**/*"
generateReleaseNotes: true
token: ${{ secrets.CI_TOKEN }}
allowUpdates: true
tag: ${{ needs.configure.outputs.commit-ref }}
name: ${{ needs.configure.outputs.commit-ref }}
Expand Down
6 changes: 3 additions & 3 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@

# __get_download_url returns the download URL for the given file, for the latest or the given GitHub release.
def __get_download_url(file: str) -> str:
if not 'current_version' in html_context or not __is_sem_version(html_context['current_version']):
if 'current_version' not in html_context or not __is_sem_version(html_context['current_version']):
return f"https://github.com/liqotech/liqo/releases/latest/download/{file}"
else:
return f"https://github.com/liqotech/liqo/releases/download/{html_context['current_version']}/{file}"
Expand Down Expand Up @@ -137,11 +137,11 @@ def generate_liqoctl_install(platform: str, arch: str) -> str:

# __is_sem_version returns True if the given string is a semantic version or the 'stable' string.
def __is_sem_version(version: str) -> bool:
return version == 'stable' or semver.VersionInfo.isvalid(version)
return version == 'stable' or semver.VersionInfo.isvalid(version.lstrip("v"))

# generate_liqoctl_version_warning generates the liqoctl version warning when the documentation is not for a released version.
def generate_liqoctl_version_warning() -> str:
if not 'github_version' in html_context or not __is_sem_version(html_context['github_version']):
if 'github_version' not in html_context or not __is_sem_version(html_context['github_version']):
return "```{warning}\n\
The following instructions will guide you through the installation of the **latest stable version of *liqoctl***, which might exhibit a different behavior compared to the one shown in the rest of this documentation. If you want to use the latest *liqoctl* version, [build it from source](InstallationLiqoctlFromSource).\n\
```\n"
Expand Down

0 comments on commit 460a67a

Please sign in to comment.