Rename crdReplicator to crdreplicator for docker compliance

.github/workflows/integration.yml

@@ -27,7 +27,7 @@ jobs:
         if [ "$GITHUB_EVENT_NAME" == "pull_request" ]; then
           echo "::set-output name=master::false"
           echo "::set-output name=commit_ref::${{ github.event.pull_request.head.sha }}"
-        elif [ ! -z VERSION ]; then
+        elif [ "${{ steps.get_version.outputs.VERSION }}" != "" ]; then
           echo "::set-output name=master::false"
           echo "::set-output name=commit_ref::${{ steps.get_version.outputs.VERSION }}"
         else
@@ -36,7 +36,7 @@ jobs:
         fi
 
         # The suffix to append to the repository name if not triggered by a push to master
-        [[ "${{ github.event_name }}" == "push" && -z VERSION ]] && \
+        [[ "${{ steps.get_version.outputs.VERSION }}" == "" ]] && \
           echo "::set-output name=repo-suffix::-ci" ||
           echo "::set-output name=repo-suffix::"
 
@@ -64,7 +64,7 @@ jobs:
         - init-pod-mutator
         - pod-mutator
         - peering-request-webhook-init
-        - crdreplicator
+        - crd-replicator
     steps:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v1
@@ -85,8 +85,8 @@ jobs:
         uses: docker/build-push-action@v2
         with:
           tags: |
-            liqo/${{ matrix.component }}:latest
-            liqo/${{ matrix.component }}:${{ needs.configure.outputs.commit_ref }}
+            liqo/${{ matrix.component }}${{ needs.configure.outputs.repo-suffix }}:latest
+            liqo/${{ matrix.component }}${{ needs.configure.outputs.repo-suffix }}:${{ needs.configure.outputs.commit_ref }}
           push: ${{ needs.configure.outputs.repo-push }}
           file: build/${{ matrix.component }}/Dockerfile
 
@@ -104,18 +104,7 @@ jobs:
        - uses: actions/checkout@v2
          with:
            ref: "${{ env.commit_ref }}"
-       - name: "Make scripts executable"
-         run: chmod +x ./scripts/utils/*
-       - name: "Set PR number"
-         run: echo "branch_owner=`git log -1 --format='%ae' $commit_ref^!`"
-       - name: "Install python dependencies"
-         run: pip install requests
-       - name: "Notify PR Event to Liqops"
-         run: |
-           curl -X POST https://api.github.com/repos/liqotech/${{ matrix.component }}/dispatches \
-           -u ${{ secrets.CI_TOKEN }} \
-           --data '
-       - name: Notify Event to CrownOps
+       - name: Notify Event to ${{ matrix.component }}
          uses: peter-evans/repository-dispatch@v1
          with:
            token: ${{ secrets.CI_TOKEN }}
@@ -214,7 +203,6 @@ jobs:
         curl -L -O "https://github.com/kubernetes-sigs/kubebuilder/releases/download/v${version}/kubebuilder_${version}_linux_${arch}.tar.gz"
         tar -zxvf kubebuilder_${version}_linux_${arch}.tar.gz
         mv kubebuilder_${version}_linux_${arch} kubebuilder && sudo mv kubebuilder /usr/local/
-        export PATH=$PATH:/usr/local/kubebuilder/bin
 
     - name: Get dependencies for Test execution
       run: |

build/crd-replicator/Dockerfile

@@ -0,0 +1,11 @@
+FROM golang:1.13 as builder
+ENV PATH /go/bin:/usr/local/go/bin:$PATH
+ENV GOPATH /go
+COPY . /go/src/github.com/liqotech/liqo
+WORKDIR /go/src/github.com/liqotech/liqo
+RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build ./cmd/crd-replicator/
+RUN cp crd-replicator /usr/bin/crd-replicator
+
+FROM scratch
+COPY --from=builder /usr/bin/crd-replicator /usr/bin/crd-replicator
+ENTRYPOINT [ "/usr/bin/crd-replicator" ]

cmd/crdReplicator/main.go → cmd/crd-replicator/main.go

@@ -72,15 +72,15 @@ func main() {
 		RemoteDynSharedInformerFactory: make(map[string]dynamicinformer.DynamicSharedInformerFactory),
 	}
 	if err = d.SetupWithManager(mgr); err != nil {
-		klog.Error(err, "unable to setup the crdReplicator-operator")
+		klog.Error(err, "unable to setup the crdreplicator-operator")
 		os.Exit(1)
 	}
 	err = d.WatchConfiguration(cfg, &configv1alpha1.GroupVersion)
 	if err != nil {
 		klog.Error(err)
 		os.Exit(-1)
 	}
-	klog.Info("Starting crdReplicator-operator")
+	klog.Info("Starting crdreplicator-operator")
 	if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
 		klog.Error(err, "problem running manager")
 		os.Exit(1)

deployments/liqo/Chart.yaml

@@ -57,4 +57,4 @@ dependencies:
 - name: crdReplicator
   version: "0.1.0"
   repository: file://subcharts/crdReplicator/
-  condition: crdReplicator.enabled
+  condition: crdreplicator.enabled

deployments/liqo/subcharts/crdReplicator/templates/crdReplicator.yaml

@@ -108,7 +108,7 @@ spec:
         - image: {{ .Values.image.repository }}{{ .Values.global.suffix | default .Values.suffix }}:{{ .Values.global.version | default .Values.version }}
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           name: crdreplicator-operator
-          command: ["/usr/bin/crdReplicator"]
+          command: ["/usr/bin/crd-replicator"]
           env:
             - name: NAMESPACE
               valueFrom:

deployments/liqo/subcharts/crdReplicator/values.yaml

@@ -1,9 +1,9 @@
-# Default values for crdReplicator.
+# Default values for crdreplicator.
 # This is a YAML-formatted file.
 # Declare variables to be passed into your templates.
 
 image:
-  repository: liqo/crdreplicator
+  repository: liqo/crd-replicator
   pullPolicy: IfNotPresent
   # Overrides the image tag whose default is the chart appVersion.
 

deployments/liqo/values.yaml

@@ -87,7 +87,7 @@ liqodash:
 
 crdReplicator:
   image:
-    repository: "liqo/crdreplicator"
+    repository: "liqo/crd-replicator"
     pullPolicy: "IfNotPresent"
   enabled: true
 

internal/discovery/discovery-config.go

@@ -29,13 +29,13 @@ func (discovery *DiscoveryCtrl) GetDiscoveryConfig(crdClient *crdClient.CRDClien
 }
 
 func (discovery *DiscoveryCtrl) handleDispatcherConfig(config configv1alpha1.DispatcherConfig) {
-	role, err := discovery.crdClient.Client().RbacV1().ClusterRoles().Get(context.TODO(), "crdReplicator-role", metav1.GetOptions{})
+	role, err := discovery.crdClient.Client().RbacV1().ClusterRoles().Get(context.TODO(), "crdreplicator-role", metav1.GetOptions{})
 	create := false
 	if errors.IsNotFound(err) {
 		// create it
 		role = &rbacv1.ClusterRole{
 			ObjectMeta: metav1.ObjectMeta{
-				Name: "crdReplicator-role",
+				Name: "crdreplicator-role",
 			},
 			Rules: []rbacv1.PolicyRule{},
 		}

internal/discovery/foreign-cluster-operator/foreign-cluster-controller.go

@@ -593,7 +593,7 @@ func (r *ForeignClusterReconciler) getForeignConfig(clusterID string, owner *dis
 		return "", err
 	}
 
-	// crdReplicator role binding
+	// crdreplicator role binding
 	err = r.setDispatcherRole(clusterID, sa)
 	if err != nil {
 		return "", err
@@ -804,12 +804,12 @@ func (r *ForeignClusterReconciler) createRoleBindingIfNotExists(clusterID string
 }
 
 func (r *ForeignClusterReconciler) setDispatcherRole(clusterID string, sa *apiv1.ServiceAccount) error {
-	_, err := r.crdClient.Client().RbacV1().ClusterRoleBindings().Get(context.TODO(), clusterID+"-crdReplicator", metav1.GetOptions{})
+	_, err := r.crdClient.Client().RbacV1().ClusterRoleBindings().Get(context.TODO(), clusterID+"-crdreplicator", metav1.GetOptions{})
 	if errors.IsNotFound(err) {
 		// does not exist
 		rb := &rbacv1.ClusterRoleBinding{
 			ObjectMeta: metav1.ObjectMeta{
-				Name: clusterID + "-crdReplicator",
+				Name: clusterID + "-crdreplicator",
 				OwnerReferences: []metav1.OwnerReference{
 					{
 						APIVersion: "v1",
@@ -829,7 +829,7 @@ func (r *ForeignClusterReconciler) setDispatcherRole(clusterID string, sa *apiv1
 			RoleRef: rbacv1.RoleRef{
 				APIGroup: "rbac.authorization.k8s.io",
 				Kind:     "ClusterRole",
-				Name:     "crdReplicator-role",
+				Name:     "crdreplicator-role",
 			},
 		}
 		_, err = r.crdClient.Client().RbacV1().ClusterRoleBindings().Create(context.TODO(), rb, metav1.CreateOptions{})

test/unit/crdReplicator/env_test.go

@@ -75,7 +75,7 @@ func startDispatcherOperator() {
 	}
 	err = dOperator.WatchConfiguration(newConfig, &configv1alpha1.GroupVersion)
 	if err != nil {
-		klog.Errorf("an error occurred while starting the configuration watcher of crdReplicator operator: %s", err)
+		klog.Errorf("an error occurred while starting the configuration watcher of crdreplicator operator: %s", err)
 		os.Exit(-1)
 	}
 	fc := getForeignClusterResource()

test/unit/reflector/reflector.go

@@ -0,0 +1 @@
+package reflector