Network Api enhancement and refactoring #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacuku
force-pushed
the
kcl/networkApiRefactoring
branch
from
ad72143
to
3c83fda
Compare
5 tasks
|
/rebase |
|
Rebase status: success! |
adamjensenbot
force-pushed
the
kcl/networkApiRefactoring
branch
from
3c83fda
to
5937986
Compare
palexster
reviewed
Aug 11, 2020
There was a problem hiding this comment.
Hi @alacuku, thanks for this compelling PRs. I suggested some very small changes and additions. I would add a further point: it would be nice to change the version of Liqo API to something less stable than v1, which says that those APIs will not change. Something like a v1alpha1, v1beta1 or similar would be more appropriate. Since you are introducing new APIs in this PR, I was wondering if this can be handled here at least for network configuration.
fraborg
approved these changes
Aug 12, 2020
alacuku
force-pushed
the
kcl/networkApiRefactoring
branch
2 times, most recently
from
6f55bf7
to
0d2bfb9
Compare
|
/rebase |
Refactoring of the network api
|
Rebase status: success! |
adamjensenbot
force-pushed
the
kcl/networkApiRefactoring
branch
from
0d2bfb9
to
62dac68
Compare
This was referenced Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the
networkconfig.liqonet.liqo.ioCRD to the network api. This CRD is contains all the network parameters to be shared with a possible foreign cluster. It is used to derive thetunnelendpoint.liqonet.liqo.ioCRD which models a VPN tunnel between two clusters.Some refactoring on the network API has been done
This PR is linked to #151