Removing the GatewayPrivateIP parameter from the network module #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
a0fca3c
to
d0b2fb2
Compare
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
2 times, most recently
from
7479198
to
dc2c244
Compare
|
/hold Waiting to fix the CI cluster in order to run E2E tests. |
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
7 times, most recently
from
be2436d
to
d356f5b
Compare
|
/rebase |
|
Rebase status: success! |
adamjensenbot
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
d356f5b
to
115fede
Compare
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
2 times, most recently
from
c7d5620
to
2072a4c
Compare
|
/rebase |
|
Rebase status: success! |
adamjensenbot
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
2072a4c
to
f1e5a16
Compare
|
Hi @alacuku ! Thanks for this! Could you please update the install documentation and the installer script accordingly to this modification? |
The install documentation does not mention the gateway already. |
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
f1e5a16
to
1ee67a6
Compare
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
1ee67a6
to
49f6b0f
Compare
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
49f6b0f
to
0ede4ac
Compare
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
6 times, most recently
from
a51e030
to
b7ca5a2
Compare
done, and updated the helm chart as well. |
|
/rebase |
|
Rebase status: success! |
adamjensenbot
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
b7ca5a2
to
17bad26
Compare
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
17bad26
to
b7ca5a2
Compare
Route-operator gets the configuration from the clusterconfig.policy.liqo.io CRD
alacuku
force-pushed
the
kcl/removingGatewayPrivateIp
branch
from
b7ca5a2
to
e29c628
Compare
|
/rebase |
|
Rebase status: success! |
fraborg
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the GatewayPrivateIP parameter from the network module. The Linux kernel does not strictly require a IP address for the tunnel interface in order to route the traffic through it. By removing this parameter we greatly simplify the configuration of a LIQO cluster.
Now the traffic from hosts to remote pods is NATed in two different ways:
The parameter have been removed from the install script and from the helm chart as well.
The route-operator gets the podCIDR parameters from the
clusterconfig.policy.liqo.ioCRD.How Has This Been Tested?
The unit tests of the network module have been updated to not consider the iptables rules and routes involving the GatewayPrivateIP parameter.
End to End tests with two k8s-clusters:
Both pod to pod traffic and node to pod traffic have been tested.