Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: labels and annotations #1836

Merged
merged 1 commit into from
May 29, 2023
Merged

Helm: labels and annotations #1836

merged 1 commit into from
May 29, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented May 26, 2023 •
edited

Description

This PR adds the possibility to specify labels for the Prometheus Operator resources.

#1835

How Has This Been Tested?

  • Locally with KinD

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 changed the title Frc/prometheus operator resources Metrics: labels in Prometheus Operator resources May 26, 2023
@cheina97 cheina97 force-pushed the frc/prometheusOperatorResources branch from 82a62c5 to 1beeca0 Compare May 26, 2023 13:04
@cheina97 cheina97 linked an issue May 26, 2023 that may be closed by this pull request
[Feature] Provide option to specify Prometheus ServiceMonitor/PodMonitor labels #1835
Closed
@cheina97 cheina97 force-pushed the frc/prometheusOperatorResources branch 3 times, most recently from e433865 to f64ce7f Compare May 26, 2023 13:59
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 26, 2023
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 marked this pull request as ready for review May 26, 2023 14:01
@Sharathmk99
Copy link
Contributor

Thank you @cheina97 Looking forward good the next release.

@cheina97 cheina97 force-pushed the frc/prometheusOperatorResources branch from f64ce7f to 3742185 Compare May 26, 2023 14:56
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 requested a review from aleoli May 26, 2023 15:28
@cheina97 cheina97 force-pushed the frc/prometheusOperatorResources branch from 3742185 to 6162978 Compare May 26, 2023 15:30
@cheina97 cheina97 changed the title Metrics: labels in Prometheus Operator resources Helm: labels and annotations May 26, 2023
@cheina97 cheina97 force-pushed the frc/prometheusOperatorResources branch from 6162978 to e253d59 Compare May 26, 2023 15:31
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frc/prometheusOperatorResources branch from e253d59 to 85c11ca Compare May 29, 2023 14:53
@cheina97 cheina97 linked an issue May 29, 2023 that may be closed by this pull request
auth.config.portOverride not being used by the service template #1827
Open
@cheina97 cheina97 mentioned this pull request May 29, 2023
Open
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 force-pushed the frc/prometheusOperatorResources branch from 0deff10 to 85c11ca Compare May 29, 2023 16:36
@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label May 29, 2023
@adamjensenbot adamjensenbot merged commit 7cbcc4f into liqotech:master May 29, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label May 29, 2023
@cheina97 cheina97 deleted the frc/prometheusOperatorResources branch May 29, 2023 16:48
@cheina97 cheina97 added the kind/feature New feature or request label May 30, 2023
@chenrui333 chenrui333 mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/M
Projects
None yet
Milestone
No milestone
4 participants
@cheina97 @adamjensenbot @Sharathmk99 @aleoli