Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liqoctl: install flags priority over provider #1838

Merged
merged 1 commit into from
May 30, 2023
Merged

Liqoctl: install flags priority over provider #1838

merged 1 commit into from
May 30, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented May 29, 2023 •
edited

Description

This PR gives priority to some liqoctl install flags, so they are able to override the provider settings.

How Has This Been Tested?

  • Locally with KinD with --service-type NodePort
  • On EKS with --cluster-name

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 marked this pull request as ready for review May 29, 2023 14:49
@cheina97 cheina97 requested review from aleoli and fra98 May 29, 2023 14:53
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 added the kind/feature New feature or request label May 30, 2023
@cheina97 cheina97 requested a review from fra98 May 30, 2023 08:36
@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label May 30, 2023
@adamjensenbot adamjensenbot merged commit 47459d4 into liqotech:master May 30, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label May 30, 2023
@cheina97 cheina97 deleted the frc/values branch May 30, 2023 10:03
@chenrui333 chenrui333 mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
kind/feature New feature or request size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheina97 @adamjensenbot @aleoli @fra98